fix pylint line-too-long errors in tests #697
Conversation
alanchen-1
requested review from
marvinpfoertner,
JonathanWenger,
pnkraemer,
schmidtjonathan and
a team
as code owners
| err_msg="""Covariance of system matrix estimate does not | ||
| match naive implementation.""", |
There was a problem hiding this comment.
| err_msg="""Covariance of system matrix estimate does not | |
| match naive implementation.""", | |
| err_msg=( | |
| "Covariance of system matrix estimate does not match naive implementation." | |
| ), |
since we don't really want a line break in the error message
| err_msg="""Covariance of matrix inverse estimate does not | ||
| match naive implementation.""", |
| err_msg="""Covariance of system matrix estimate does not | ||
| match naive implementation.""", |
There was a problem hiding this comment.
See comment in test_matrix_based_linear_belief_update.py
| err_msg="""Covariance of matrix inverse estimate does not | ||
| match naive implementation.""", |
There was a problem hiding this comment.
See comment in test_matrix_based_linear_belief_update.py
tests/test_randvars/test_normal.py
Outdated
| err_msg = """Mean and kernels mismatch in normal distribution | ||
| did not raise a ValueError.""" |
There was a problem hiding this comment.
See comment in test_matrix_based_linear_belief_update.py
tests/test_randvars/test_normal.py
Outdated
| msg=f"""Sample {i} from symmetric Kronecker | ||
| distribution is not symmetric.""", |
There was a problem hiding this comment.
See comment in test_matrix_based_linear_belief_update.py
| @@ -80,4 +80,3 @@ commands = | |||
| # pylint benchmarks --disable="unused-argument,attribute-defined-outside-init,missing-function-docstring" --jobs=0 # not a work in progress, but final | |||
| pylint benchmarks --disable="unused-argument,attribute-defined-outside-init,no-else-return,no-self-use,consider-using-from-import,missing-module-docstring,missing-class-docstring,missing-function-docstring" --jobs=0 | |||
| # pylint tests --disable="missing-function-docstring" --jobs=0 # not a work in progress, but final | |||
| pylint tests --disable="arguments-differ,redefined-outer-name,too-many-instance-attributes,too-many-arguments,too-many-locals,too-few-public-methods,protected-access,unnecessary-pass,unused-variable,unused-argument,unused-private-member,attribute-defined-outside-init,no-else-return,no-self-use,consider-using-from-import,duplicate-code,line-too-long,missing-module-docstring,missing-class-docstring,missing-function-docstring,missing-param-doc,missing-type-doc,missing-raises-doc,missing-return-type-doc,redundant-returns-doc" --jobs=0 | |||
There was a problem hiding this comment.
Removing this line skips running pylint on the tests entirely. Please only remove the disabled line-too-long message
|
Shoot, didn't notice the linebreak things. Thanks for catching that, I just fixed them to all be in the parens format. |
No worries :) |
JonathanWenger
added
the
testing and CI
|
In |
In a Nutshell
Fixes pylint
line-too-longerrors in thetestspackage.Detailed Description
Refactors some files in the
testspackage to comply with pylintline-too-longerrors.Related Issues
Closes #673